Re: [PATCH v2] pinctrl: devicetree: fix refcount leak in pinctrl_dt_to_map()

[Andy Shevchenko]

On Thu, Apr 18, 2024 at 07:34:59PM +0800, Zeng Heng wrote:
> If we fail to allocate propname buffer, we need to drop the reference
> count we just took, otherwise it will lead reference leak. Here the
> error exit path is modified to jump to the err label and call
> pinctrl_dt_free_maps() which would drop the counter.
> 
> In the meantime, if it is found that the property 'pinctrl-0' is not
> present, ENODEV is returned and also jump to the err label and call the
> free function, in case the Smatch tool complains.

> ---

You forgot a changelog, but I think this needs to be a followup.

-- 
With Best Regards,
Andy Shevchenko