Re: [PATCH net-next v3 4/5] net: stmmac: add support for RZ/N1 GMAC

From: Romain Gantois
Date: Thu Apr 18 2024 - 07:57:23 EST


Hi Serge,

On Tue, 16 Apr 2024, Serge Semin wrote:

> > +static int rzn1_dwmac_pcs_init(struct stmmac_priv *priv,
>
> > + struct mac_device_info *hw)
>
> AFAICS hw is unused, and the mac_device_info instance is reached via
> the priv pointer. What about dropping the unused argument then?

Unfortunately, this is an implementation of the pcs_init() callback, which is
also used by socfpga (see patch 4/6 in this series). The socfpga implementations
use the hw parameter for both pcs_init() and pcs_exit() so I can't remove it.

Thanks,

--
Romain Gantois, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com