Re: [PATCH] Documentation: workqueue: Inline WQ_* flag pattern

From: Bagas Sanjaya
Date: Thu Apr 18 2024 - 09:11:54 EST


On 4/18/24 15:23, Akira Yokosawa wrote:
> [+Cc: Jon]
>
> On Thu, 18 Apr 2024 14:21:01 +0700, Bagas Sanjaya wrote:
>> - * For detailed information on %WQ_* flags, please refer to
>> + * For detailed information on ``WQ_*`` flags, please refer to
>> * Documentation/core-api/workqueue.rst.
>> *
>> * RETURNS:
>
> In my opinion, reST-specific clutters like these should be avoided in
> kernel-doc comments as far as possible.
>
> Instead, I think you can educate kernel-doc (script) so that "*" is
> allowed in the %CONSTANT pattern, meaning %WQ_* can be converted
> to ``WQ_*`` in reST.
>
> For similar changes made against the @param pattern, see commits
> 69fc23efc7e5 ("kernel-doc: Add unary operator * to $type_param_ref")
> and 8aaf297a0dd6 ("docs: scripts: kernel-doc: accept bitwise negation
> like ~@var").
>

Thanks for the idea!

--
An old man doll... just what I always wanted! - Clara