Re: [PATCH net v2] udp: don't be set unconnected if only UDP cmsg

[Willem de Bruijn]

Paolo Abeni wrote:
> Hi,
> 
> On Wed, 2024-04-17 at 03:03 +0800, Yick Xie wrote:
> > If "udp_cmsg_send()" returned 0 (i.e. only UDP cmsg),
> > "connected" should not be set to 0. Otherwise it stops
> > the connected socket from using the cached route.
> > 
> > Fixes: 2e8de8576343 ("udp: add gso segment cmsg")
> > Signed-off-by: Yick Xie <yick.xie@xxxxxxxxx>
> > Cc: stable@xxxxxxxxxxxxxxx
> 
> Minor: the patch subj is IMHO a bit confusing, what about removing the
> double negation?
> 
> preserve connect status with UDP-only cmsg
> 
> > ---
> > v2: Add Fixes tag
> > v1: https://lore.kernel.org/netdev/20240414195213.106209-1-yick.xie@xxxxxxxxx/
> > ---
> >  net/ipv4/udp.c | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> > 
> > diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c
> > index c02bf011d4a6..420905be5f30 100644
> > --- a/net/ipv4/udp.c
> > +++ b/net/ipv4/udp.c
> 
> What about ipv6? why this fix does not apply there, too?

Oops. Thanks Paolo. Yes, this definitely also applies to ipv6.