Re: [PATCHv10 03/18] cpu/hotplug: Add support for declaring CPU offlining not supported

From: Borislav Petkov
Date: Thu Apr 18 2024 - 10:37:55 EST


On Tue, Apr 09, 2024 at 02:29:55PM +0300, Kirill A. Shutemov wrote:
> +/* Declare CPU offlining not supported */
> +void cpu_hotplug_disable_offlining(void)
> +{
> + cpu_maps_update_begin();

"/*
* The following two APIs (cpu_maps_update_begin/done) must be used when
* attempting to serialize the updates to cpu_online_mask & cpu_present_mask.
*/
void cpu_maps_update_begin(void)
.."

> + cpu_hotplug_offline_disabled = true;

but this doesn't do that here.

Are we doing a one-off here for that variable or what?

> + cpu_maps_update_done();

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette