Re: [PATCH 1/2] dt-bindings: arm: rockchip: correct the model name for Radxa ROCK 3A

From: Dragan Simic
Date: Thu Apr 18 2024 - 11:46:42 EST


Hello Conor,

On 2024-04-18 17:37, Conor Dooley wrote:
On Thu, Apr 18, 2024 at 05:21:18PM +0200, Dragan Simic wrote:
On 2024-04-18 15:01, Chukun Pan wrote:
> According to https://radxa.com/products/rock3/3a,
> the name of this board should be "Radxa ROCK 3A".
> Also update compatible to match the model name.
>
> Suggested-by: FUKAUMI Naoki <naoki@xxxxxxxxx>
> Signed-off-by: Chukun Pan <amadeus@xxxxxxxxxx>

Looking good to me. I'll send the remaining naming cleanup patches
a bit later.

What remaining patches?

The same naming cleanups need to be performed for the Radxa
ROCK 5 boards. [1] I had some more cleanups for the ROCK 4
boards in mind, but I'll drop them after your NAK. [2]

Though, I'm not really sure why the NAK? Those names aren't
used anywhere, neither in the Linux kernel, nor in U-Boot.

[1] https://lore.kernel.org/linux-rockchip/B26C732A4DCEA9B3+282b8775-601b-4d4a-a513-4924b7940076@xxxxxxxxx/
[2] https://lore.kernel.org/linux-rockchip/20240418-liberty-pry-d270065a544f@spud/