Re: 回复: [v1] staging: media: starfive: Clean pad selection in isp_try_format()

From: Dan Carpenter
Date: Thu Apr 18 2024 - 13:19:36 EST


On Thu, Apr 18, 2024 at 01:27:04AM +0000, Changhuang Liang wrote:
> Hi, Hans
>
> > The code to select isp_dev->formats[] is overly complicated. We can just use
> > the "pad" as the index. This will making adding new pads easier in future
> > patches. No functional change.
> >
> > Signed-off-by: Changhuang Liang <changhuang.liang@xxxxxxxxxxxxxxxx>
> > ---
>
> Could you please help to review this patch, thanks for your time.

Linux-media uses patchwork, so probably it was missed because it didn't
have a [PATCH] in the subject. Just resend.

regards,
dan carpenter