Re: [PATCH 2/3] dt-bindings: mfd: add schema for 8ulp AVD-SIM

From: Frank Li
Date: Thu Apr 18 2024 - 17:10:50 EST


On Thu, Apr 18, 2024 at 11:37:19PM +0300, Laurentiu Mihalcea wrote:
> From: Laurentiu Mihalcea <laurentiu.mihalcea@xxxxxxx>
>
> Add schema for i.MX8ULP's AVD-SIM module.
>
> Signed-off-by: Liu Ying <victor.liu@xxxxxxx>
> Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@xxxxxxx>
> ---
> .../bindings/mfd/fsl,imx8ulp-avd-sim.yaml | 42 +++++++++++++++++++
> 1 file changed, 42 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mfd/fsl,imx8ulp-avd-sim.yaml
>
> diff --git a/Documentation/devicetree/bindings/mfd/fsl,imx8ulp-avd-sim.yaml b/Documentation/devicetree/bindings/mfd/fsl,imx8ulp-avd-sim.yaml
> new file mode 100644
> index 000000000000..4020c6e37f80
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/fsl,imx8ulp-avd-sim.yaml
> @@ -0,0 +1,42 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mfd/fsl,imx8ulp-avd-sim.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NXP i.MX8ULP Audio-Video Domain System Integration Module
> +
> +maintainers:
> + - Liu Ying <victor.liu@xxxxxxx>
> +
> +description: |
> + The AVD-SIM module provides configuration options for components of AVD.

Needn't "|"

> +
> +properties:
> + compatible:
> + items:
> + - const: fsl,imx8ulp-avd-sim
> + - const: syscon
> + - const: simple-mfd
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/imx8ulp-clock.h>
> + avd_sim: syscon@2da50000 {

Needn't label 'avd_sim'

> + compatible = "fsl,imx8ulp-avd-sim", "syscon", "simple-mfd";
> + reg = <0x2da50000 0x38>;
> + clocks = <&pcc5 IMX8ULP_CLK_AVD_SIM>;
> + };
> --
> 2.34.1
>