Re: [PATCH v1 02/18] mm/rmap: always inline anon/file rmap duplication of a single PTE

From: Yin, Fengwei
Date: Thu Apr 18 2024 - 22:26:28 EST




On 4/10/2024 3:22 AM, David Hildenbrand wrote:
As we grow the code, the compiler might make stupid decisions and
unnecessarily degrade fork() performance. Let's make sure to always inline
functions that operate on a single PTE so the compiler will always
optimize out the loop and avoid a function call.

This is a preparation for maintining a total mapcount for large folios.

Signed-off-by: David Hildenbrand<david@xxxxxxxxxx>
The patch looks good to me. Just curious: Is this change driven by code
reviewing or performance data profiling? Thanks.


Regards
Yin, Fengwei