Re: [PATCH v3 2/2] kunit: avoid memory leak on device register error
From: Greg Kroah-Hartman
Date: Fri Apr 19 2024 - 02:34:13 EST
On Fri, Apr 19, 2024 at 08:15:25AM +0200, Markus Elfring wrote:
> > If the device register fails, free the allocated memory before
> > returning.
>
> Can a description variant (like the following) be more appropriate?
>
> Free the allocated memory (after a device registration failure)
> before returning.
> Thus add a jump target so that a bit of exception handling can be better
> reused at the end of this function implementation.
>
>
> Would you like to replace the word “register” by “registration” also
> in the summary phrase?
>
Hi,
This is the semi-friendly patch-bot of Greg Kroah-Hartman.
Markus, you seem to have sent a nonsensical or otherwise pointless
review comment to a patch submission on a Linux kernel developer mailing
list. I strongly suggest that you not do this anymore. Please do not
bother developers who are actively working to produce patches and
features with comments that, in the end, are a waste of time.
Patch submitter, please ignore Markus's suggestion; you do not need to
follow it at all. The person/bot/AI that sent it is being ignored by
almost all Linux kernel maintainers for having a persistent pattern of
behavior of producing distracting and pointless commentary, and
inability to adapt to feedback. Please feel free to also ignore emails
from them.
thanks,
greg k-h's patch email bot