Re: [PATCH v2 0/2] sched/eevdf: Minor fixes for reweight_entity()
From: Peter Zijlstra
Date: Fri Apr 19 2024 - 04:03:27 EST
On Fri, Apr 19, 2024 at 03:27:30PM +0800, Chen Yu wrote:
> On 2024-03-06 at 10:21:31 +0800, Tianchen Ding wrote:
> > According to the discussion in [1], fix a calculation bug in
> > reweight_entity().
> >
> > [1] https://lore.kernel.org/all/59585184-d13d-46e0-8d68-42838e97a702@xxxxxxxxxxxxx/
> >
> > v2:
> > Add fixes tag to the 1st patch.
> >
> > v1: https://lore.kernel.org/all/20240304030042.2690-1-dtcccc@xxxxxxxxxxxxxxxxx/
> >
> > Tianchen Ding (2):
> > sched/eevdf: Always update V if se->on_rq when reweighting
> > sched/eevdf: Fix miscalculation in reweight_entity() when se is not
> > curr
> >
> > kernel/sched/fair.c | 12 ++++++------
> > 1 file changed, 6 insertions(+), 6 deletions(-)
> >
> > --
> > 2.39.3
> >
>
> Applied this patch set on top of the reweight_entity fix at
> https://lore.kernel.org/lkml/ZiEaKOQwiNEglYtS@chenyu5-mobl2/
> it has passed 100 cycles of trinity test without any issue.
>
> For the whole serie,
>
> Tested-by: Chen Yu <yu.c.chen@xxxxxxxxx>
OK, grabbed these patches (and made some minor edits), now let me go
stare at that other thread again.