Re: [PATCH v3 14/17] drm/mediatek: add MT8365 SoC support

[Alexandre Mergnat]

On 19/04/2024 10:01, AngeloGioacchino Del Regno wrote:
> Il 18/04/24 16:17, amergnat@xxxxxxxxxxxx ha scritto:
> > From: Fabien Parent <fparent@xxxxxxxxxxxx>
> >
> > Add DRM support for MT8365 SoC.
> >
> > Signed-off-by: Fabien Parent <fparent@xxxxxxxxxxxx>
> > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
> > Signed-off-by: Alexandre Mergnat <amergnat@xxxxxxxxxxxx>
>
> There are two things that I want to point out. Please check below.
>
> The series that I've sent for adding OF Graphs [1] support to MediaTek DRM is
> not going to be picked in time for v6.10, but I think neither your MT8365 support
> series is, and that's why I'm telling you this.
>
> If your work was based off my series, you would not need to add the MT8365 ddp
> MAIN and EXT paths to mtk_drm_drv: you'd just add it to the bindings and then
> you would declare the paths in devicetree.

Ok then I will rebase my v4 on top of your serie

> [1]: https://lore.kernel.org/r/20240409120211.321153-1-angelogioacchino.delregno@xxxxxxxxxxxxx
>
> There's also one more comment....
>
> > ---
> >   drivers/gpu/drm/mediatek/mtk_drm_drv.c | 30 ++++++++++++++++++++++++++++++
> >   1 file changed, 30 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> > index 74832c213092..427b601309c4 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
>
> ..snip..
>
> > @@ -793,6 +821,8 @@ static const struct of_device_id mtk_ddp_comp_dt_ids[] = {
> >         .data = (void *)MTK_DSI },
> >       { .compatible = "mediatek,mt8188-dsi",
> >         .data = (void *)MTK_DSI },
> > +    { .compatible = "mediatek,mt8365-dpi",
>
> You removed the mt8365 specific compatible from the DPI driver - why did you keep
> it here?! that's not needed! :-)

Sorry for that, I forgot to remove it in this driver too. Thanks to catched it.

> Cheers,
> Angelo
>
> > +      .data = (void *)MTK_DPI },
> >       { }
> >   };

--
Regards,
Alexandre