Re: [PATCH v7 3/3] virt: vmgenid: add support for devicetree bindings

[Jason A. Donenfeld]

Hi Rob,

On Fri, Apr 19, 2024 at 3:30 PM Landge, Sudan <sudanl@xxxxxxxxxxxx> wrote:
> >   config VMGENID
> >          tristate "Virtual Machine Generation ID driver"
> >          default y
> > -       depends on ACPI
> > +       depends on ACPI || OF
>
> Version 2 of the patches had these flag but were removed in version3
> following the below review comment from Rob:
> "One of those is pretty much always enabled, so it can probably be dropped."
> reference :
> https://lore.kernel.org/lkml/CAL_JsqJoB5CYajWuntMdQrJZir+ZA-69Q0cwvxcVZAqs-mXC+Q@xxxxxxxxxxxxxx/

Are you sure about that? I see other drivers that depend on `ACPI ||
OF`, and this driver is totally useless without either disabled
(right?), so the dependency makes sense. I think? Not an expert in
this area, so I'm happy to defer to what you know is best, but I did
want to lightly pushback a bit.

Jason