Re: [PATCH] drm: bridge: cdns-mhdp8546: Fix missing mutex unlock on error path

From: Dmitry Baryshkov
Date: Fri Apr 19 2024 - 11:02:58 EST


On Fri, Apr 19, 2024 at 02:36:37PM +0300, Aleksandr Mishin wrote:
> In cdns_mhdp_atomic_enable(), there is an error return on failure of
> drm_mode_duplicate() which leads to the mutex remaining locked.
> Add a mutex unlock call.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: 935a92a1c400 ("drm: bridge: cdns-mhdp8546: Fix possible null pointer dereference")
> Signed-off-by: Aleksandr Mishin <amishin@xxxxxxxxxx>
> ---
> This patch is against drm-misc-next branch of drm-misc repo.
>
> drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
>


Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>


--
With best wishes
Dmitry