Re: [PATCH 00/15] tty: serial: switch from circ_buf to kfifo

From: Neil Armstrong
Date: Fri Apr 19 2024 - 11:13:20 EST

Next message: Benjamin Tissoires: "Re: [PATCH bpf-next 17/18] bpf: add bpf_wq_start"
Previous message: Benjamin Tissoires: "Re: [PATCH bpf-next 11/18] bpf: wq: add bpf_wq_init"
Next in thread: Greg KH: "Re: [PATCH 00/15] tty: serial: switch from circ_buf to kfifo"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Hi Jiri,

On 05/04/2024 08:08, Jiri Slaby (SUSE) wrote:

This series switches tty serial layer to use kfifo instead of circ_buf.

The reasoning can be found in the switching patch in this series:
"""
Switch from struct circ_buf to proper kfifo. kfifo provides much better
API, esp. when wrap-around of the buffer needs to be taken into account.
Look at pl011_dma_tx_refill() or cpm_uart_tx_pump() changes for example.

Kfifo API can also fill in scatter-gather DMA structures, so it easier
for that use case too. Look at lpuart_dma_tx() for example. Note that
not all drivers can be converted to that (like atmel_serial), they
handle DMA specially.

Note that usb-serial uses kfifo for TX for ages.
"""

Cc: Al Cooper <alcooperx@xxxxxxxxx>
Cc: Alexander Shiyan <shc_work@xxxxxxx>
Cc: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>
Cc: Alexandre Torgue <alexandre.torgue@xxxxxxxxxxx>
Cc: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>
Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Cc: "Aneesh Kumar K.V" <aneesh.kumar@xxxxxxxxxx>
Cc: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
Cc: Baolin Wang <baolin.wang@xxxxxxxxxxxxxxxxx>
Cc: Baruch Siach <baruch@xxxxxxxxxx>
Cc: Bjorn Andersson <andersson@xxxxxxxxxx>
Cc: Claudiu Beznea <claudiu.beznea@xxxxxxxxx>
Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
Cc: Fabio Estevam <festevam@xxxxxxxxx>
Cc: Hammer Hsieh <hammerh0314@xxxxxxxxx>
Cc: "Christian König" <christian.koenig@xxxxxxx>
Cc: Christophe Leroy <christophe.leroy@xxxxxxxxxx>
Cc: Chunyan Zhang <zhang.lyra@xxxxxxxxx>
Cc: Jerome Brunet <jbrunet@xxxxxxxxxxxx>
Cc: Jonathan Hunter <jonathanh@xxxxxxxxxx>
Cc: Kevin Hilman <khilman@xxxxxxxxxxxx>
Cc: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
Cc: Kumaravel Thiagarajan <kumaravel.thiagarajan@xxxxxxxxxxxxx>
Cc: Laxman Dewangan <ldewangan@xxxxxxxxxx>
Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
Cc: linux-arm-msm@xxxxxxxxxxxxxxx
Cc: "Maciej W. Rozycki" <macro@xxxxxxxxxxx>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>
Cc: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>
Cc: Matthias Brugger <matthias.bgg@xxxxxxxxx>
Cc: Maxime Coquelin <mcoquelin.stm32@xxxxxxxxx>
Cc: Michael Ellerman <mpe@xxxxxxxxxxxxxx>
Cc: Michal Simek <michal.simek@xxxxxxx>
Cc: "Naveen N. Rao" <naveen.n.rao@xxxxxxxxxxxxx>
Cc: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
Cc: Nicolas Ferre <nicolas.ferre@xxxxxxxxxxxxx>
Cc: Nicholas Piggin <npiggin@xxxxxxxxx>
Cc: Orson Zhai <orsonzhai@xxxxxxxxx>
Cc: "Pali Rohár" <pali@xxxxxxxxxx>
Cc: Patrice Chotard <patrice.chotard@xxxxxxxxxxx>
Cc: Peter Korsgaard <jacmet@xxxxxxxxxx>
Cc: Richard Genoud <richard.genoud@xxxxxxxxx>
Cc: Russell King <linux@xxxxxxxxxxxxxxx>
Cc: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
Cc: Shawn Guo <shawnguo@xxxxxxxxxx>
Cc: Stefani Seibold <stefani@xxxxxxxxxxx>
Cc: Sumit Semwal <sumit.semwal@xxxxxxxxxx>
Cc: Taichi Sugaya <sugaya.taichi@xxxxxxxxxxxxx>
Cc: Takao Orito <orito.takao@xxxxxxxxxxxxx>
Cc: Tharun Kumar P <tharunkumar.pasumarthi@xxxxxxxxxxxxx>
Cc: Thierry Reding <thierry.reding@xxxxxxxxx>
Cc: Timur Tabi <timur@xxxxxxxxxx>
Cc: Vineet Gupta <vgupta@xxxxxxxxxx>

Jiri Slaby (SUSE) (15):
kfifo: drop __kfifo_dma_out_finish_r()
kfifo: introduce and use kfifo_skip_count()
kfifo: add kfifo_out_linear{,_ptr}()
kfifo: remove support for physically non-contiguous memory
kfifo: rename l to len_to_end in setup_sgl()
kfifo: pass offset to setup_sgl_buf() instead of a pointer
kfifo: add kfifo_dma_out_prepare_mapped()
kfifo: fix typos in kernel-doc
tty: 8250_dma: use dmaengine_prep_slave_sg()
tty: 8250_omap: use dmaengine_prep_slave_sg()
tty: msm_serial: use dmaengine_prep_slave_sg()
tty: serial: switch from circ_buf to kfifo
tty: atmel_serial: use single DMA mapping for TX
tty: atmel_serial: define macro for RX size
tty: atmel_serial: use single DMA mapping for RX

drivers/tty/serial/8250/8250_bcm7271.c | 14 +--
drivers/tty/serial/8250/8250_core.c | 3 +-
drivers/tty/serial/8250/8250_dma.c | 31 +++--
drivers/tty/serial/8250/8250_exar.c | 5 +-
drivers/tty/serial/8250/8250_mtk.c | 2 +-
drivers/tty/serial/8250/8250_omap.c | 48 +++++---
drivers/tty/serial/8250/8250_pci1xxxx.c | 50 ++++----
drivers/tty/serial/8250/8250_port.c | 22 ++--
drivers/tty/serial/amba-pl011.c | 46 +++-----
drivers/tty/serial/ar933x_uart.c | 15 ++-
drivers/tty/serial/arc_uart.c | 8 +-
drivers/tty/serial/atmel_serial.c | 150 +++++++++++-------------
drivers/tty/serial/clps711x.c | 12 +-
drivers/tty/serial/cpm_uart.c | 20 ++--
drivers/tty/serial/digicolor-usart.c | 12 +-
drivers/tty/serial/dz.c | 13 +-
drivers/tty/serial/fsl_linflexuart.c | 17 +--
drivers/tty/serial/fsl_lpuart.c | 39 +++---
drivers/tty/serial/icom.c | 25 +---
drivers/tty/serial/imx.c | 54 ++++-----
drivers/tty/serial/ip22zilog.c | 26 ++--
drivers/tty/serial/jsm/jsm_cls.c | 29 ++---
drivers/tty/serial/jsm/jsm_neo.c | 38 ++----
drivers/tty/serial/max3100.c | 14 +--
drivers/tty/serial/max310x.c | 35 +++---
drivers/tty/serial/men_z135_uart.c | 26 ++--
drivers/tty/serial/meson_uart.c | 11 +-
drivers/tty/serial/milbeaut_usio.c | 15 +--
drivers/tty/serial/msm_serial.c | 114 +++++++++---------
drivers/tty/serial/mvebu-uart.c | 8 +-
drivers/tty/serial/mxs-auart.c | 23 +---
drivers/tty/serial/pch_uart.c | 21 ++--
drivers/tty/serial/pic32_uart.c | 15 ++-
drivers/tty/serial/pmac_zilog.c | 24 ++--
drivers/tty/serial/qcom_geni_serial.c | 36 +++---
drivers/tty/serial/rda-uart.c | 17 +--
drivers/tty/serial/samsung_tty.c | 54 +++++----
drivers/tty/serial/sb1250-duart.c | 13 +-
drivers/tty/serial/sc16is7xx.c | 40 +++----
drivers/tty/serial/sccnxp.c | 16 ++-
drivers/tty/serial/serial-tegra.c | 43 ++++---
drivers/tty/serial/serial_core.c | 56 ++++-----
drivers/tty/serial/serial_port.c | 2 +-
drivers/tty/serial/sh-sci.c | 51 ++++----
drivers/tty/serial/sprd_serial.c | 20 ++--
drivers/tty/serial/st-asc.c | 4 +-
drivers/tty/serial/stm32-usart.c | 52 ++++----
drivers/tty/serial/sunhv.c | 35 +++---
drivers/tty/serial/sunplus-uart.c | 16 +--
drivers/tty/serial/sunsab.c | 30 ++---
drivers/tty/serial/sunsu.c | 15 +--
drivers/tty/serial/sunzilog.c | 27 ++---
drivers/tty/serial/tegra-tcu.c | 10 +-
drivers/tty/serial/timbuart.c | 17 ++-
drivers/tty/serial/uartlite.c | 13 +-
drivers/tty/serial/ucc_uart.c | 20 ++--
drivers/tty/serial/xilinx_uartps.c | 20 ++--
drivers/tty/serial/zs.c | 13 +-
include/linux/kfifo.h | 143 ++++++++++++++++------
include/linux/serial_core.h | 49 +++++---
lib/kfifo.c | 107 +++++++++--------
61 files changed, 944 insertions(+), 960 deletions(-)

This patchset has at least broken all Amlogic and Qualcomm boards so far, only part of them were fixed in next- but this serie has been merged in v1 with no serious testing and should've been dropped immediately when the first regressions were reported.

Thanks,
Neil

Next message: Benjamin Tissoires: "Re: [PATCH bpf-next 17/18] bpf: add bpf_wq_start"
Previous message: Benjamin Tissoires: "Re: [PATCH bpf-next 11/18] bpf: wq: add bpf_wq_init"
Next in thread: Greg KH: "Re: [PATCH 00/15] tty: serial: switch from circ_buf to kfifo"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]