Re: [PATCH v5 0/3] arm64: dts: qcom: apq8016: Add Schneider HMIBSC board DTS

[Sumit Garg]

On Tue, 9 Apr 2024 at 23:24, Sumit Garg <sumit.garg@xxxxxxxxxx> wrote:
>
> Hi Bjorn, Konrad,
>
> On Wed, 3 Apr 2024 at 10:04, Sumit Garg <sumit.garg@xxxxxxxxxx> wrote:
> >
> > Add Schneider Electric HMIBSC board DTS. The HMIBSC board is an IIoT Edge
> > Box Core board based on the Qualcomm APQ8016E SoC. For more information
> > refer to the product page [1].
> >
> > One of the major difference from db410c is serial port where HMIBSC board
> > uses UART1 as the debug console with a default RS232 mode (UART1 mode mux
> > configured via gpio99 and gpio100).
> >
> > Support for Schneider Electric HMIBSC. Features:
> > - Qualcomm Snapdragon 410C SoC - APQ8016 (4xCortex A53, Adreno 306)
> > - 1GiB RAM
> > - 8GiB eMMC, SD slot
> > - WiFi and Bluetooth
> > - 2x Host, 1x Device USB port
> > - HDMI
> > - Discrete TPM2 chip over SPI
> > - USB ethernet adaptors (soldered)
> >
> > This series is a v2 since v1 of this DTS file has been reviewed on the
> > U-Boot mailing list [2].
> >
> > Changes in v5:
> > - Addressed another nitpick from Stephen.
> > - Collected Stephen's review tag.
> > - Warnings reported by Rob's DT check bot aren't related to HMIBSC
> >   board DTS but rather they are due to msm8916.dtsi or extcon-usb-gpio.txt
> >   still not converted to YAML format.
> >
>
> I haven't seen any further comments on this series, can you help to pick it up?

Gentle reminder.

-Sumit

>
> > Changes in v4:
> > - Dropped IRQ_TYPE_EDGE_FALLING for pm8916_resin given the expectations
> >   of Linux kernel driver. Instead depend on systemd workaround suggested
> >   by Caleb to get expected HMIBSC reset behaviour.
> > - Incorporated further DT coding style comments from Stephen.
> > - Warnings reported by Rob's DT check bot aren't related to HMIBSC
> >   board DTS but rather they are due to msm8916.dtsi or extcon-usb-gpio.txt
> >   still not converted to YAML format.
> >
> > Changes in v3:
> > - Picked up tags.
> > - Fixed further DT schema warnings.
> > - Configure resin/power button interrupt as falling edge.
> > - Incorporate DTS coding style comments from Krzysztof and Konrad.
> >
> > Changes in v2:
> > - Fix DT schema warnings.
> > - Incorporate suggestions from Stephan.
> > - Document UART1 mode GPIOs based mux.
> >
> > [1] https://www.se.com/us/en/product/HMIBSCEA53D1L0T/iiot-edge-box-core-harmony-ipc-emmc-dc-linux-tpm/
> > [2] https://patchwork.ozlabs.org/project/uboot/patch/20240311111027.44577-6-sumit.garg@xxxxxxxxxx/
> >
> > Sumit Garg (3):
> >   dt-bindings: vendor-prefixes: Add Schneider Electric
> >   dt-bindings: arm: qcom: Add Schneider Electric HMIBSC board
> >   arm64: dts: qcom: apq8016: Add Schneider HMIBSC board DTS
> >
> >  .../devicetree/bindings/arm/qcom.yaml         |   1 +
> >  .../devicetree/bindings/vendor-prefixes.yaml  |   2 +
> >  arch/arm64/boot/dts/qcom/Makefile             |   1 +
> >  .../dts/qcom/apq8016-schneider-hmibsc.dts     | 491 ++++++++++++++++++
> >  4 files changed, 495 insertions(+)
> >  create mode 100644 arch/arm64/boot/dts/qcom/apq8016-schneider-hmibsc.dts
> >
> > --
> > 2.34.1
> >