[PATCH net v2 0/3] net: gro: add flush/flush_id checks and fix wrong offset in udp

[Richard Gobert]

This series fixes a bug in the complete phase of UDP in GRO, in which
socket lookup fails due to using network_header when parsing encapsulated
packets. The fix is to add network_offset and inner_network_offset to
napi_gro_cb and use these offsets for socket lookup.

In addition p->flush/flush_id should be checked in all UDP flows. The
same logic from tcp_gro_receive is applied for all the flows in
udp_gro_receive_segment. This prevents packets with mismatching network
headers (flush/flush_id turned on) from merging in UDP GRO.

The original series includes a change to vxlan test which adds the local
parameter to prevent similar future bugs. I plan to submit it separately to
net-next.

This series is part of a previously submitted series to net-next:
https://lore.kernel.org/all/20240408141720.98832-1-richardbgobert@xxxxxxxxx/

v1 -> v2:
 - Use network_offsets instead of p_poff param as suggested by Willem
 - Check flush before postpull, and for all UDP GRO flows (previously
   reviewed by Willem, and was changed since)
 - v1:
 https://lore.kernel.org/netdev/20240412152120.115067-1-richardbgobert@xxxxxxxxx/

Richard Gobert (3):
  net: gro: add {inner_}network_offset to napi_gro_cb
  net: gro: fix udp bad offset in socket lookup
  net: gro: add flush check in udp_gro_receive_segment

 drivers/net/geneve.c           |  1 +
 drivers/net/vxlan/vxlan_core.c |  1 +
 include/net/gro.h              | 18 ++++++++++++++++--
 net/8021q/vlan_core.c          |  2 ++
 net/core/gro.c                 |  1 +
 net/ethernet/eth.c             |  1 +
 net/ipv4/af_inet.c             |  5 +----
 net/ipv4/gre_offload.c         |  1 +
 net/ipv4/udp.c                 |  3 ++-
 net/ipv4/udp_offload.c         | 15 +++++++++++++--
 net/ipv6/ip6_offload.c         |  8 ++++----
 net/ipv6/udp.c                 |  3 ++-
 net/ipv6/udp_offload.c         |  3 ++-
 13 files changed, 47 insertions(+), 15 deletions(-)

-- 
2.36.1