Re: [PATCH net-next 2/2] net: phy: adin: add support for setting led-, link-status-pin polarity

From: Andrew Lunn
Date: Fri Apr 19 2024 - 11:47:27 EST


On Fri, Apr 19, 2024 at 05:35:18PM +0200, Josua Mayer wrote:
> ADIN1300 supports software control over pin polarity for both LED_0 and
> LINK_ST pins.
>
> Configure the polarity during probe based on device-tree properties.
>
> Led polarity is only set if specified in device-tree, otherwise the phy
> can choose either active-low or active-high based on external line
> voltage. Link-status polarity is set to active-high as default if not
> specified, which is always the reset-default.
>
> Signed-off-by: Josua Mayer <josua@xxxxxxxxxxxxx>

Hi Josua

Please take a look at:

commit 447b80a9330ef2d9a94fc5a9bf35b6eac061f38b
Author: Alexander Stein <alexander.stein@xxxxxxxxxxxxxxx>
Date: Wed Jan 31 08:50:48 2024 +0100

net: phy: dp83867: Add support for active-low LEDs

Add the led_polarity_set callback for setting LED polarity.

Signed-off-by: Alexander Stein <alexander.stein@xxxxxxxxxxxxxxx>
Reviewed-by: Andrew Lunn <andrew@xxxxxxx>
Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>


Andrew

---
pw-bot: cr