Re: [PATCH 0/5] string: Merge separate tests into string_kunit.c

From: Ivan Orlov
Date: Fri Apr 19 2024 - 12:28:22 EST


On 4/19/24 15:01, Kees Cook wrote:
Hi,

We have a few lone function tests (strscpy and strcat) that are better
collected into the common string_kunit.c test suite. Perform various
renamings, merge everything, and clean up after them.

-Kees

Kees Cook (5):
string: Prepare to merge strscpy_kunit.c into string_kunit.c
string: Merge strscpy KUnit tests into string_kunit.c
string: Prepare to merge strcat KUnit tests into string_kunit.c
string: Merge strcat KUnit tests into string_kunit.c
string: Convert KUnit test names to standard convention

MAINTAINERS | 2 -
lib/Kconfig.debug | 10 --
lib/Makefile | 2 -
lib/strcat_kunit.c | 104 ------------------
lib/string_kunit.c | 258 +++++++++++++++++++++++++++++++++++++++-----
lib/strscpy_kunit.c | 142 ------------------------
6 files changed, 230 insertions(+), 288 deletions(-)
delete mode 100644 lib/strcat_kunit.c
delete mode 100644 lib/strscpy_kunit.c


I tested all of the patches in the series with kunit_tool, and everything works correctly.

Thank you for doing this!

Tested-by: Ivan Orlov <ivan.orlov0322@xxxxxxxxx>
--
Kind regards,
Ivan Orlov