Re: [PATCHv2 next] ptp: update gettimex64 to provide ts optionally in mono-raw base.

[Mahesh Bandewar (महेश बंडेवार)]

On Thu, Apr 18, 2024 at 6:55 PM Jakub Kicinski <kuba@xxxxxxxxxx> wrote:
>
> On Wed, 17 Apr 2024 21:27:06 -0700 Mahesh Bandewar wrote:
> > --- a/include/uapi/linux/ptp_clock.h
> > +++ b/include/uapi/linux/ptp_clock.h
> > @@ -157,7 +157,12 @@ struct ptp_sys_offset {
> >
> >  struct ptp_sys_offset_extended {
> >       unsigned int n_samples; /* Desired number of measurements. */
> > -     unsigned int rsv[3];    /* Reserved for future use. */
> > +     /* The original implementation provided timestamps (always) in
> > +      * REALTIME clock-base. Since CLOCK_REALTIME is 0, adding
> > +      * clockid doesn't break backward compatibility.
> > +      */
> > +     clockid_t clockid;      /* One of the supported clock-ids */
> > +     unsigned int rsv[2];    /* Reserved for future use. */
>
> This suffers from a moderate inability to build:
>
> usr/include/linux/ptp_clock.h:164:2: error: unknown type name 'clockid_t'
>   164 |         clockid_t clockid;      /* One of the supported clock-ids */
>       |         ^
Hmm, my bad, it didn't fail while I was testing/building. I should
watch the bot checks more carefully :(
I'll fix it in the next revision.
> --
> pw-bot: cr