Re: [PATCHv1 next] ptp: update gettimex64 to provide ts optionally in mono-raw base.

[Jakub Kicinski]

On Thu, 18 Apr 2024 23:28:48 -0700 Richard Cochran wrote:
> On Wed, Apr 17, 2024 at 06:24:45PM -0700, Jakub Kicinski wrote:
> > On Tue, 16 Apr 2024 14:59:42 -0700 Mahesh Bandewar wrote:  
> > >  		if (extoff->n_samples > PTP_MAX_SAMPLES
> > > -		    || extoff->rsv[0] || extoff->rsv[1] || extoff->rsv[2]) {
> > > +		    || extoff->rsv[0] || extoff->rsv[1]
> > > +		    || (extoff->clockid != CLOCK_REALTIME
> > > +			&& extoff->clockid != CLOCK_MONOTONIC_RAW)) {  
> > 
> > Since you're touching this condition it's probably a good opportunity
> > to fox the coding style.  
> 
> What is the CodingStyle violation?
> 
> Is it starting a line with  ||  ?

Yup. Now that it's a mix of || and && the loss of readability 
to a kernel-trained eye starts to be impactful.