Re: [PATCH v3 0/5] RK3588 and Rock 5B dts additions: thermal, OPP and fan

From: Diederik de Haas
Date: Sat Apr 20 2024 - 13:54:21 EST

Hi Dragan and Alexey,

On Wednesday, 10 April 2024 11:28:09 CEST Dragan Simic wrote:
> > Can you rebase this patch set on Heiko's for-next branch [1]?
> > And then also fix the ordering of the nodes and the elements within
> > those nodes so that they match the current conventions?
>
> Ah, thanks, this is a good reminder about the proposal for the plan
> for moving forward, which I promised to send a while ago. :)
>
> > [1]
> > https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git/l
> > og/?h=for-next

I build a (Debian) kernel based off 6.9-rc4 + a whole bunch of patches,
including this patch series. I got someone on #debian-arm to try it out on a
Rock 5B and the dmesg output showed a number of items wrt thermal and OPP.

Some items that I filtered out from that dmesg output:

[ 3.211716] hwmon hwmon0: temp1_input not attached to any thermal zone
[ 3.908339] panthor fb000000.gpu: EM: OPP:900000 is inefficient
[ 10.473061] cpu cpu0: EM: OPP:600000 is inefficient
[ 10.473233] energy_model: Accessing cpu4 policy failed
[ 10.585236] rockchip-thermal fec00000.tsadc: Missing rockchip,grf property

Attached is the full list of items I collected from that dmesg output which
seem worth investigating.

Maybe useful to investigate when moving forward?

Cheers,
DiederikRadxa 5B issues (dmesg on https://termbin.com/e170):

[ 2.863508] rockchip-spi feb20000.spi: Runtime PM usage count underflow!

[ 2.915650] rtc-hym8563 6-0051: no valid clock/calendar values available
[ 2.915949] rtc-hym8563 6-0051: registered as rtc0
[ 2.916945] rtc-hym8563 6-0051: no valid clock/calendar values available
[ 2.916950] rtc-hym8563 6-0051: hctosys: unable to read the hardware clock

[ 2.994580] rockchip-drm display-subsystem: [drm:rockchip_drm_platform_probe [rockchipdrm]] *ERROR* No available vop found for display-subsystem.
[ 3.101020] rockchip-dw-pcie a40000000.pcie: PCIe Gen.3 x4 link up
[ 3.101308] rockchip-dw-pcie a40000000.pcie: PCI host bridge to bus 0000:00
[ 3.101316] pci_bus 0000:00: root bus resource [bus 00-0f]
[ 3.101324] pci_bus 0000:00: root bus resource [io 0x0000-0xfffff] (bus address [0xf0100000-0xf01fffff])
[ 3.101329] pci_bus 0000:00: root bus resource [mem 0xf0200000-0xf0ffffff]
[ 3.101335] pci_bus 0000:00: root bus resource [mem 0x900000000-0x93fffffff] (bus address [0x40000000-0x7fffffff])
[ 3.101357] pci 0000:00:00.0: [1d87:3588] type 01 class 0x060400 PCIe Root Port
[ 3.101369] pci 0000:00:00.0: BAR 0 [mem 0x00000000-0x3fffffff]
[ 3.101377] pci 0000:00:00.0: BAR 1 [mem 0x00000000-0x3fffffff]
[ 3.101384] pci 0000:00:00.0: ROM [mem 0x00000000-0x0000ffff pref]
[ 3.101389] pci 0000:00:00.0: PCI bridge to [bus 01-ff]
[ 3.101396] pci 0000:00:00.0: bridge window [io 0x0000-0x0fff]
[ 3.101402] pci 0000:00:00.0: bridge window [mem 0x00000000-0x000fffff]
[ 3.101410] pci 0000:00:00.0: bridge window [mem 0x00000000-0x000fffff 64bit pref]
[ 3.101452] pci 0000:00:00.0: supports D1 D2
[ 3.101457] pci 0000:00:00.0: PME# supported from D0 D1 D3hot
[ 3.103848] pci_bus 0000:01: busn_res: can not insert [bus 01-ff] under [bus 00-0f] (conflicts with (null) [bus 00-0f])
[ 3.103921] pci 0000:01:00.0: [144d:a809] type 00 class 0x010802 PCIe Endpoint
[ 3.103987] pci 0000:01:00.0: BAR 0 [mem 0x00000000-0x00003fff 64bit]
[ 3.116969] pci 0000:00:00.0: BAR 0 [mem 0x900000000-0x93fffffff]: assigned
[ 3.116983] pci 0000:00:00.0: BAR 1 [mem size 0x40000000]: can't assign; no space
[ 3.116990] pci 0000:00:00.0: BAR 1 [mem size 0x40000000]: failed to assign
[ 3.116995] pci 0000:00:00.0: bridge window [mem 0xf0200000-0xf02fffff]: assigned
[ 3.117001] pci 0000:00:00.0: ROM [mem 0xf0300000-0xf030ffff pref]: assigned
[ 3.117009] pci 0000:01:00.0: BAR 0 [mem 0xf0200000-0xf0203fff 64bit]: assigned
[ 3.117042] pci 0000:00:00.0: PCI bridge to [bus 01-ff]
[ 3.117048] pci 0000:00:00.0: bridge window [mem 0xf0200000-0xf02fffff]

[ 3.211716] hwmon hwmon0: temp1_input not attached to any thermal zone
[ 3.211775] hwmon hwmon0: temp2_input not attached to any thermal zone
[ 3.211823] hwmon hwmon0: temp3_input not attached to any thermal zone

[ 3.327532] pci 0002:20:00.0: bridge configuration invalid ([bus 01-ff]), reconfiguring

[ 3.908339] panthor fb000000.gpu: EM: OPP:900000 is inefficient
[ 3.908349] panthor fb000000.gpu: EM: OPP:800000 is inefficient
[ 3.908354] panthor fb000000.gpu: EM: OPP:700000 is inefficient
[ 3.908358] panthor fb000000.gpu: EM: OPP:600000 is inefficient
[ 3.908361] panthor fb000000.gpu: EM: OPP:500000 is inefficient
[ 3.908365] panthor fb000000.gpu: EM: OPP:400000 is inefficient
[ 3.908369] panthor fb000000.gpu: EM: OPP:300000 is inefficient

[ 3.920149] [drm] Initialized panthor 1.0.0 20230801 for fb000000.gpu on minor 0

[ 4.483910] dwmmc_rockchip fe2d0000.mmc: Busy; trying anyway
[ 5.213383] mmc_host mmc2: Timeout sending command (cmd 0x202000 arg 0x0 status 0x80202000)
[ 5.228057] mmc_host mmc2: Bus speed (slot 0) = 300000Hz (slot req 300000Hz, actual 300000HZ div = 0)

[ 7.072323] dwmmc_rockchip fe2d0000.mmc: Busy; trying anyway
[ 7.801690] mmc_host mmc2: Timeout sending command (cmd 0x202000 arg 0x0 status 0x80202000)
[ 7.816350] mmc_host mmc2: Bus speed (slot 0) = 187500Hz (slot req 187500Hz, actual 187500HZ div = 0)
[ 8.369904] dwmmc_rockchip fe2d0000.mmc: Busy; trying anyway
[ 9.099376] mmc_host mmc2: Timeout sending command (cmd 0x202000 arg 0x0 status 0x80202000)
[ 9.101395] mmc2: Failed to initialize a non-removable card

[ 10.473061] cpu cpu0: EM: OPP:600000 is inefficient
[ 10.473075] cpu cpu0: EM: OPP:408000 is inefficient
[ 10.473227] cpu cpu0: EM: created perf domain
[ 10.473233] energy_model: Accessing cpu4 policy failed
[ 10.483901] cpu cpu4: EM: OPP:2352000 is inefficient
[ 10.483914] cpu cpu4: EM: OPP:2304000 is inefficient
[ 10.483918] cpu cpu4: EM: OPP:2256000 is inefficient
[ 10.483923] cpu cpu4: EM: OPP:1008000 is inefficient
[ 10.483926] cpu cpu4: EM: OPP:816000 is inefficient
[ 10.483930] cpu cpu4: EM: OPP:600000 is inefficient
[ 10.483934] cpu cpu4: EM: OPP:408000 is inefficient
[ 10.484193] cpu cpu4: EM: created perf domain
[ 10.484199] energy_model: Accessing cpu6 policy failed
[ 10.488907] cpu cpu6: EM: OPP:2352000 is inefficient
[ 10.488917] cpu cpu6: EM: OPP:2304000 is inefficient
[ 10.488921] cpu cpu6: EM: OPP:2256000 is inefficient
[ 10.488925] cpu cpu6: EM: OPP:1008000 is inefficient
[ 10.488928] cpu cpu6: EM: OPP:816000 is inefficient
[ 10.488932] cpu cpu6: EM: OPP:600000 is inefficient
[ 10.488936] cpu cpu6: EM: OPP:408000 is inefficient
[ 10.489175] cpu cpu6: EM: created perf domain
[ 10.489179] energy_model: updating cpu0 cpu_cap=397 old capacity=530
[ 10.489186] cpu cpu0: EM: OPP:816000 is inefficient
[ 10.489190] cpu cpu0: EM: OPP:600000 is inefficient
[ 10.489194] cpu cpu0: EM: OPP:408000 is inefficient
[ 10.585236] rockchip-thermal fec00000.tsadc: Missing rockchip,grf property

Attachment: signature.asc
Description: This is a digitally signed message part.