Re: [PATCH v21 6/9] usb: dwc3: qcom: Add helper function to request wakeup interrupts

From: Johan Hovold
Date: Mon Apr 22 2024 - 03:23:10 EST


On Sat, Apr 20, 2024 at 10:18:58AM +0530, Krishna Kurapati wrote:
> The logic for requesting interrupts is duplicated for each interrupt. In
> the upcoming patches that introduces support for multiport, it would be
> better to clean up the duplication before reading mulitport related
> interrupts.
>
> Refactor interrupt setup call by adding a new helper function for
> requesting the wakeup interrupts. To simplify implementation, make
> the display name same as the interrupt name expected in Device tree.
>
> Signed-off-by: Krishna Kurapati <quic_kriskura@xxxxxxxxxxx>
> Reviewed-by: Bjorn Andersson <quic_bjorande@xxxxxxxxxxx>

As far I can see, you only replaced "DT" with "Device tree" in the
commit message. For changes like that you could have kept my
Reviewed-by tag (but I appreciate that you dropped it from some of the
others):

Reviewed-by: Johan Hovold <johan+linaro@xxxxxxxxxx>