Re: [PATCH v2 1/4] virtio_balloon: separate vm events into a function

From: David Hildenbrand
Date: Mon Apr 22 2024 - 03:47:17 EST


On 22.04.24 09:42, zhenwei pi wrote:
All the VM events related statistics have dependence on
'CONFIG_VM_EVENT_COUNTERS', once any stack variable is required by any
VM events in future, we would have codes like:
#ifdef CONFIG_VM_EVENT_COUNTERS
unsigned long foo;
#endif
...
#ifdef CONFIG_VM_EVENT_COUNTERS
foo = events[XXX] + events[YYY];
update_stat(vb, idx++, VIRTIO_BALLOON_S_XXX, foo);
#endif

Separate vm events into a single function, also remove

Why not simply use __maybe_unused for that variable?

--
Cheers,

David / dhildenb