Re: [PATCH] arm64: dts: rockchip: move uart2 pinmux to dtsi on rk3588-tiger

From: Quentin Schulz
Date: Mon Apr 22 2024 - 04:44:17 EST


Hi Heiko,

On 4/19/24 10:03, Heiko Stuebner wrote:
From: Heiko Stuebner <heiko.stuebner@xxxxxxxxx>

The association of uart2 to the q7-uart pins is part of the module
itself and not the baseboard used. Therefore move the pinctrl over
to the tiger dtsi.

Signed-off-by: Heiko Stuebner <heiko.stuebner@xxxxxxxxx>

Could have squeezed in a comment to state that this UART is the UART0 signals on Q7 because I often have to reopen the schematics/carrierboard DTS to remember which uart controller of which SoM is used for the debug console :)

In any case,

Reviewed-by: Quentin Schulz <quentin.schulz@xxxxxxxxxxxxxxxxxxxxx>

Thanks,
Quentin