Re: [PATCH v8 0/3] virt: vmgenid: add devicetree bindings support

From: Babis Chalios
Date: Mon Apr 22 2024 - 09:30:24 EST


On 4/20/24 00:39, Jason A. Donenfeld wrote:
Changes v7->v8:
- Remove Kconfig depends statement entirely, instead of ACPI||OF.
- Check platform_get_irq() return value against < 0 rather than !0.

This is a cleanup of Sudan's OF vmgenid patches, simplified a bit, but
still with the same intent and mostly unchanged. I'll take this via my
random tree, but Krzysztof, I would appreciate having your ack/review on
it.

Sudan - if I've mangled something here, please let me know. I verified
this still works with ACPI in QEMU, but I don't know about your private
firecracker OF branch, so please pipe up if something is amiss. It's
basically the same thing, though, so I suspect it'll be fine.

Hi Jason,

I also verified that this still works with ACPI on Firecracker.
I also verified that the OF part of the patch works with this:
https://github.com/sudanl0/firecracker/commit/f382e09a9b1e4453d2b231232d89bcb85296ac87
patch on top of Firecracker.

Tested-by: Babis Chalios <bchalios@xxxxxxxxx>

Cheers,
Babis