Re: [PATCH v3 4/4] arm64: dts: add description for solidrun cn9131 solidwan board

[Andrew Lunn]

On Sun, Apr 14, 2024 at 01:18:56PM +0000, Josua Mayer wrote:
> Am 14.04.24 um 14:58 schrieb Josua Mayer:
> > Add description for the SolidRun CN9131 SolidWAN, based on CN9130 SoM
> > with an extra communication  processor on the carrier board.
> >
> > This board differentiates itself from CN9130 Clearfog by providing
> > additional SoC native network interfaces and pci buses:
> > 2x 10Gbps SFP+
> > 4x 1Gbps RJ45
> > 1x miniPCI-E
> > 1x m.2 b-key with sata, usb-2.0 and usb-3.0
> > 1x m.2 m-key with pcie and usb-2.0
> > 1x m.2 b-key with pcie, usb-2.0, usb-3.0 and 2x sim slots
> > 1x mpcie with pcie only
> > 2x type-a usb-2.0/3.0
> >
> > Signed-off-by: Josua Mayer <josua@xxxxxxxxxxxxx>
> > ---
> >  arch/arm64/boot/dts/marvell/Makefile               |   1 +
> >  arch/arm64/boot/dts/marvell/cn9131-cf-solidwan.dts | 653 +++++++++++++++++++++
> >  2 files changed, 654 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/marvell/Makefile b/arch/arm64/boot/dts/marvell/Makefile
> > index 019f2251d696..16f9d7156d9f 100644
> > --- a/arch/arm64/boot/dts/marvell/Makefile
> > +++ b/arch/arm64/boot/dts/marvell/Makefile
> > @@ -30,3 +30,4 @@ dtb-$(CONFIG_ARCH_MVEBU) += ac5x-rd-carrier-cn9131.dtb
> >  dtb-$(CONFIG_ARCH_MVEBU) += ac5-98dx35xx-rd.dtb
> >  dtb-$(CONFIG_ARCH_MVEBU) += cn9130-cf-base.dtb
> >  dtb-$(CONFIG_ARCH_MVEBU) += cn9130-cf-pro.dtb
> > +dtb-$(CONFIG_ARCH_MVEBU) += cn9131-cf-solidwan.dtb
> > diff --git a/arch/arm64/boot/dts/marvell/cn9131-cf-solidwan.dts b/arch/arm64/boot/dts/marvell/cn9131-cf-solidwan.dts
> cut
> > +	leds {
> > +		compatible = "gpio-leds";
> > +		pinctrl-names = "default";
> > +		pinctrl-0 = <&cp0_led_pins &cp1_led_pins>;
> > +
> > +		/* for sfp-1 (J42) */
> > +		led-sfp1-activity {
> > +			label = "sfp1";
> > +			gpios = <&cp0_gpio1 7 GPIO_ACTIVE_HIGH>;
> > +			color = <LED_COLOR_ID_GREEN>;
> > +		};
> > +
> > +		/* for sfp-1 (J42) */
> > +		led-sfp1-link {
> > +			label = "sfp1";
> > +			gpios = <&cp0_gpio1 4 GPIO_ACTIVE_HIGH>;
> > +			color = <LED_COLOR_ID_YELLOW>;
> > +		};
> > +
> > +		/* (J28) */
> > +		led-sfp0-activity {
> > +			label = "sfp0";
> > +			gpios = <&cp1_gpio2 22 GPIO_ACTIVE_HIGH>;
> > +			color = <LED_COLOR_ID_GREEN>;
> > +		};
> > +
> > +		/* (J28) */
> > +		led-sfp0-link {
> > +			label = "sfp0";
> > +			gpios = <&cp1_gpio2 23 GPIO_ACTIVE_HIGH>;
> > +			color = <LED_COLOR_ID_YELLOW>;
> > +		};
> > +	};
> > +
> Here I am uncertain what to put in the label.
> Each SFP has a single dual-color (3 terminals) LED,
> with one gpio controlling each colour.
> 
> Colours are similar to RJ45 connectors (yellow, green),
> and are intended for the same purpose: link, activity.

For the switch LEDs you used label = "LED10"; Does the silk screen
have similar numbers for these LEDs?

     Andrew