Re: [PATCH] selftests: mm: fix unused and uninitialized variable warning

[Zi Yan]

On 16 Apr 2024, at 12:26, Muhammad Usama Anjum wrote:

> Fix the warnings by initializing and marking the variable as unused.
> I've caught the warnings by using clang.
>
> split_huge_page_test.c:303:6: warning: variable 'dummy' set but not used [-Wunused-but-set-variable]
>   303 |         int dummy;
>       |             ^
> split_huge_page_test.c:343:3: warning: variable 'dummy' is uninitialized when used here [-Wuninitialized]
>   343 |                 dummy += *(*addr + i);
>       |                 ^~~~~
> split_huge_page_test.c:303:11: note: initialize the variable 'dummy' to silence this warning
>   303 |         int dummy;
>       |                  ^
>       |                   = 0
> 2 warnings generated.
>
> Fixes: fc4d182316bd ("mm: huge_memory: enable debugfs to split huge pages to any order")
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@xxxxxxxxxxxxx>
> ---
>  tools/testing/selftests/mm/split_huge_page_test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
LGTM. Thanks. Reviewed-by: Zi Yan <ziy@xxxxxxxxxx>

--
Best Regards,
Yan, Zi

Attachment: signature.asc
Description: OpenPGP digital signature