Re: [PATCH v3 00/10] sysctl: Remove sentinel elements from kernel dir
From: Konstantin Ryabitsev
Date: Mon Apr 22 2024 - 10:57:34 EST
On Mon, Apr 22, 2024 at 04:49:27PM +0200, Krzysztof Kozlowski wrote:
> >> These commits remove the sentinel element (last empty element) from
> >> the
> >> sysctl arrays of all the files under the "kernel/" directory that use a
> >> sysctl array for registration. The merging of the preparation patches
> >> [1] to mainline allows us to remove sentinel elements without changing
> >> behavior. This is safe because the sysctl registration code
> >> (register_sysctl() and friends) use the array size in addition to
> >> checking for a sentinel [2].
> >
> > Hi,
> >
> > looks like *this* "patch" made it to the sysctl tree [1], breaking b4
> > for everyone else (as there's a "--- b4-submit-tracking ---" magic in
> > the tree history now) on next-20240422
> >
> > Please drop it (again, I'm only talking about this empty cover letter).
>
> Just to clarify, in case it is not obvious:
> Please *do not merge your own trees* into kernel.org repos. Instead use
> b4 shazam to pick up entire patchset, even if it is yours. b4 allows to
> merge/apply also the cover letter, if this is your intention.
>
> With b4 shazam you would get proper Link tags and not break everyone's
> b4 workflow on next. :/
I was expecting this to happen at some point. :/
Note, that you can still use b4 and merge your own trees, but you need
to switch to using a different cover letter strategy:
[b4]
prep-cover-strategy = branch-description
-K