Re: [PATCH 0/2] Bluetooth: qca: fix NULL-deref on non-serdev setup

From: Johan Hovold
Date: Mon Apr 22 2024 - 11:03:39 EST


On Mon, Apr 22, 2024 at 09:53:48PM +0800, quic_zijuhu wrote:
> On 4/22/2024 9:43 PM, Johan Hovold wrote:
> > On Mon, Apr 22, 2024 at 09:30:28PM +0800, quic_zijuhu wrote:
> >> On 4/22/2024 9:20 PM, Johan Hovold wrote:

> >> NAK for your [PATCH 1/2] since the null checking is redundant with your
> >> [PATCH 2/2].
> >
> > I explained in the cover letter why it is split up like this. If you
> > don't bother reading, then we will not bother listening to you.
> >
> >> NAK for your [PATCH 2/2], since it is same with my earlier fix
> >> https://lore.kernel.org/all/1704960978-5437-1-git-send-email-quic_zijuhu@xxxxxxxxxxx/
> >> my new patchset for btattach tool still has this change.
> >
> > The fix does not depend on your btattach series, which has also been
> > rejected.
> >
> these my v1 and v2 for this issue which are earlier then yours.
> they are not rejected but not responded.
>
> https://lore.kernel.org/all/bf74d533-c0ff-42c6-966f-b4b28c5e0f60@xxxxxxxxxxxxx/
> https://lore.kernel.org/all/1704970181-30092-1-git-send-email-quic_zijuhu@xxxxxxxxxxx/

Here is your *v3* as part of the rejected btattach series:

https://lore.kernel.org/all/1713409913-13042-2-git-send-email-quic_zijuhu@xxxxxxxxxxx/

Apparently you had earlier also sent it separately, I see now in lore.
It's all a big mess.

> > You clearly have some learning to do on how to interact with the kernel
> > community and to write proper commit messages and patches. If you start
> > listening to feedback and try not to piss everyone off perhaps you can
> > even get your patches merged one day. [1][2]

Johan