Re: [PATCH v3 1/1] dt-bindings: interrupt-controller: fsl,irqsteer: Add imx8qxp support

[Frank Li]

On Mon, Apr 22, 2024 at 08:49:49AM +0200, Alexander Stein wrote:
> Some SoC like i.MX8QXP use a power-domain for this IP. Add a SoC-specific
> compatible, which also requires a power-domain.
> 
> Signed-off-by: Alexander Stein <alexander.stein@xxxxxxxxxxxxxxx>
> ---

Next time, please cc imx@xxxxxxxxxxxxxxx

Frank

> Thanks for the feedback.
> 
> Changes in v3:
> * Move 'allOf' before 'additionalProperties'
> * Remove superfluous 'minItems: 1'
> 
>  .../interrupt-controller/fsl,irqsteer.yaml      | 17 ++++++++++++++++-
>  1 file changed, 16 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml
> index 20ad4ad82ad64..3d33b75d6ecfa 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml
> +++ b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml
> @@ -14,7 +14,9 @@ properties:
>      oneOf:
>        - const: fsl,imx-irqsteer
>        - items:
> -          - const: fsl,imx8m-irqsteer
> +          - enum:
> +              - fsl,imx8m-irqsteer
> +              - fsl,imx8qxp-irqsteer
>            - const: fsl,imx-irqsteer
>  
>    reg:
> @@ -42,6 +44,9 @@ properties:
>    clock-names:
>      const: ipg
>  
> +  power-domains:
> +    maxItems: 1
> +
>    interrupt-controller: true
>  
>    "#interrupt-cells":
> @@ -70,6 +75,16 @@ required:
>    - fsl,channel
>    - fsl,num-irqs
>  
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: fsl,imx8qxp-irqsteer
> +    then:
> +      required:
> +        - power-domains
> +
>  additionalProperties: false
>  
>  examples:
> -- 
> 2.34.1
>