Re: [PATCH] arm64/sysreg: Update ID_AA64MMFR2_EL1 register

From: Will Deacon
Date: Mon Apr 22 2024 - 13:16:24 EST


On Mon, Apr 22, 2024 at 08:38:40AM +0530, Anshuman Khandual wrote:
>
>
> On 4/19/24 19:16, Will Deacon wrote:
> > On Fri, Apr 19, 2024 at 07:43:25AM +0530, Anshuman Khandual wrote:
> >> This updates ID_AA64MMFR2_EL1.VARange register fields as per the definition
> >> based on DDI0601 2024-03.
> >>
> >> Cc: Catalin Marinas <catalin.marinas@xxxxxxx>
> >> Cc: Will Deacon <will@xxxxxxxxxx>
> >> Cc: Mark Brown <broonie@xxxxxxxxxx>
> >> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> >> Cc: linux-kernel@xxxxxxxxxxxxxxx
> >> Signed-off-by: Anshuman Khandual <anshuman.khandual@xxxxxxx>
> >> ---
> >> This applies on v6.9-rc4
> >>
> >> arch/arm64/tools/sysreg | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/arch/arm64/tools/sysreg b/arch/arm64/tools/sysreg
> >> index a4c1dd4741a4..6d7213dcbeb5 100644
> >> --- a/arch/arm64/tools/sysreg
> >> +++ b/arch/arm64/tools/sysreg
> >> @@ -1739,6 +1739,7 @@ EndEnum
> >> UnsignedEnum 19:16 VARange
> >> 0b0000 48
> >> 0b0001 52
> >> + 0b0010 56
> >
> > Is anybody using this? I'm not sure there's a lot of value in adding
> > these fields one-by-one for the sake of completeness.
>
> This is not being used currently but will be required for upcoming
> features. I was under the impression that register fields (atleast
> for the ID registers) should be kept updated, with latest released
> spec ? Besides lately arch/arm64/tools/sysreg serves as very good
> reference for all necessary register fields.

Why? The linux headers aren't documenting the architecture.

Will