Re: [PATCH v2 05/13] x86/irq: Reserve a per CPU IDT vector for posted MSIs
From: Jacob Pan
Date: Mon Apr 22 2024 - 18:28:46 EST
Hi Arnaldo,
On Fri, 19 Apr 2024 17:07:17 -0300, Arnaldo Carvalho de Melo
<acme@xxxxxxxxxx> wrote:
> > > On a second thought, if we make system IRQ vector determined at
> > > compile time based on different CONFIG options, will it break
> > > userspace tools such as perf? More importantly the rule of not
> > > breaking userspace.
>
> The rule for tools/perf is "don't impose _any requirement_ on the kernel
> developers, they don't have to test if any change they do outside of
> tools/ will break something inside tools/."
>
> > tools/arch/x86/include/asm/irq_vectors.h is only used to generate the
> > list of system vectors for pretty output. And your change already broke
> > that.
>
> Yeah, I even moved that from tools/arch/x86/include/asm/irq_vectors.h
> to tools/perf/trace/beauty/arch/x86/include/asm/irq_vectors.h (for next
> merge window).
So I will not add anything to the tools directory for my next version.
Just a heads-up for adding this new vector.
Thanks,
Jacob