Re: [PATCH 1/7] block: Init for CBD(CXL Block Device)

[Dongsheng Yang]

在 2024/4/23 星期二 上午 2:39, Randy Dunlap 写道:
> Hi,
>
> On 4/22/24 12:16 AM, Dongsheng Yang wrote:
> > diff --git a/drivers/block/cbd/Kconfig b/drivers/block/cbd/Kconfig
> > new file mode 100644
> > index 000000000000..98b2cbcdf895
> > --- /dev/null
> > +++ b/drivers/block/cbd/Kconfig
> > @@ -0,0 +1,4 @@
> > +config BLK_DEV_CBD
> > +	tristate "CXL Block Device"
> > +	help
> > +	  If unsure say 'm'.
>
> I think that needs more help text. checkpatch should have said something
> about that...
>
> And why should someone say 'm' to the config question?
> Will lots of (non-server) computers have CXL block device capability?

Hi,
    Thanx for your review! In this RFC version, I have focused entirely 
on prototype validation and demonstration, so this aspect has evidently 
been overlooked. I will supplement the help text in the next version. Of 
course, this place should be If unsure say "n", not "m".

Thanx
> thanks.