RE: [PATCH v2] cxl: Fix use of phys_to_target_node() for x86

From: Dan Williams
Date: Mon Apr 22 2024 - 20:26:52 EST


Robert Richter wrote:
> The CXL driver uses both functions phys_to_target_node() and
> memory_add_physaddr_to_nid(). The x86 architecture relies on the
> NUMA_KEEP_MEMINFO kernel option enabled for both functions to work
> correct. Update Kconfig to make sure the option is always enabled for
> the driver.
>
> Suggested-by: Dan Williams <dan.j.williams@xxxxxxxxx>

It would be nice if all "Suggested-by:" tags also came with a "Link:"
tag to recall the rationale, because my brain had cache flushed what I
said earlier.

Found it here:

Link: http://lore.kernel.org/r/65f8b191c0422_aa222941b@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx.notmuch

..with that added:

Reviewed-by: Dan Williams <dan.j.williams@xxxxxxxxx>