Re: [PATCH 4/8] ceph: drop usage of page_index

[Xiubo Li]

On 4/22/24 23:34, Kairui Song wrote:
> On Thu, Apr 18, 2024 at 9:40 AM Xiubo Li <xiubli@xxxxxxxxxx> wrote:
> > On 4/18/24 09:30, Matthew Wilcox wrote:
> > > On Thu, Apr 18, 2024 at 08:28:22AM +0800, Xiubo Li wrote:
> > > > Thanks for you patch and will it be doable to switch to folio_index()
> > > > instead ?
> > > No.  Just use folio->index.  You only need folio_index() if the folio
> > > might belong to the swapcache instead of a file.
> > Hmm, Okay.
> >
> > Thanks
> >
> > - Xiubo
> Hi Xiubo
>
> Thanks for the comment,
>
> As Matthew mentioned there is no need to use folio_index unless you
> are access swapcache. And I found that ceph is not using folios
> internally yet, needs a lot of conversions. So I think I'll just keep
> using page->index here, later conversions may change it to
> folio->index.
Sounds good to me and thanks for explaining.

Cheers

- Xiubo