Re: [PATCH -next] genirq: Reuse irq_is_nmi()

From: Jinjie Ruan
Date: Mon Apr 22 2024 - 22:17:14 EST




On 2024/4/23 5:01, Thomas Gleixner wrote:
> On Wed, Apr 17 2024 at 16:56, Jinjie Ruan wrote:
>>
>> +static bool __maybe_unused irq_is_nmi(struct irq_desc *desc)
>
> Seriously? What's wrong with static inline?

Use "static bool" has follwoing warning:

kernel/irq/internals.h:283:13: warning: ‘irq_is_nmi’ defined but not
used [-Wunused-function]
283 | static bool irq_is_nmi(struct irq_desc *desc)

But us "static inline bool" is ok.

I'll change it to inline, thank you very much!
>