RE: [PATCH v2 3/3] ras/events: Trace CXL CPER events without CXL stack
From: Ira Weiny
Date: Tue Apr 23 2024 - 00:10:54 EST
Dan Williams wrote:
> Ira Weiny wrote:
> > If CXL is solely managed by firmware (including HDM configuration and
> > event processing via firmware first) it is possible to run the system
> > without the CXL software loaded. In this case no CXL callback will be
> > loaded and CXL CPER errors will not be processed at all.
> >
> > In this case memory device and region (HPA) information is missing but
> > omitting the error completely is not friendly. Some device information
> > is available the event.
> >
> > Trace CXL CPER events if the CXL stack is not loaded. A balance was
> > chosen to decode only the CPER header as this configuration is likely
> > rare.
>
> I think the justification for this is weak and it pollutes the user ABI.
Do you want me to drop this patch or slim the tracepoint down even
further?
Looking at this again I feel like
54ce1927eb78 ("cxl/cper: Fix errant CPER prints for CXL events")
Was a mistake. PCI AER errors are both printed in
cper_estatus_print_section() and again printed/traced in pci_print_aer()
Why should CXL be any different?
Ira