Re: [PATCH v3] dt-bindings: usb: uhci: convert to dt schema

[Krzysztof Kozlowski]

On 22/04/2024 14:21, Mohammad Shehar Yaar Tausif wrote:
> Convert USB UHCI bindings to DT schema. Documenting aspeed compatibles
> and missing properties. Adding aspeed/generic-uhci example and fix previous
> incorrect example.
> 
> Signed-off-by: Mohammad Shehar Yaar Tausif <sheharyaar48@xxxxxxxxx>

> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: generic-uhci
> +    then:
> +      $ref: usb-hcd.yaml

Nothing improved here.

> +      required:
> +        - clocks

And this was not tested.

> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    uhci@d8007b00 {
> +        compatible = "platform-uhci";

What happened here? This is deprecated!

> +        reg = <0xd8007b00 0x200>;
> +        interrupts = <43>;


Best regards,
Krzysztof