Re: [PATCH] cpufreq: ti: Implement scope-based cleanup in ti_cpufreq_match_node()

From: Viresh Kumar
Date: Tue Apr 23 2024 - 03:23:24 EST


On 23-04-24, 09:11, Julia Lawall wrote:
>
>
> On Tue, 23 Apr 2024, Shivani Gupta wrote:
>
> > This patch modifies the ti_cpufreq_match_node() function to utilize the
> > __free() cleanup handler for automatically releasing the device
> > node when it goes out of scope.
> >
> > By moving the declaration to the initialization, the patch ensures that
> > the device node is properly managed throughout the function's scope,
> > thus eliminating the need for manual invocation of of_node_put().
> > This approach reduces the potential for memory leaks.
>
> The code is fine. The log message is a bit verbose. Try to avoid
> referring to the patch. It's obvious that you are talking about the
> patch. Try to favor the imperative, so "Modify..." instead of "This patch
> modifies".

Fixed while applying.

--
viresh