Re: [PATCH v3 0/2] Mesh PMU: Add tertiary match group support

[Ilkka Koskinen]

Hi Robin,

Would you have time to review v3 at some point? Hopefully, it's a little 
bit closer to what you were thinking about... :)

Cheers, Ilkka


On Fri, 29 Mar 2024, Ilkka Koskinen wrote:
> Hopefully, I got it this time and the patchset starts to look better now...
>
>
> v3:
> 	* Replaced wp_cfg in arm_cmn_hw_event with wp_idx that keeps
> 	  track, whether the event uses 0 or 1 index for the given direction
> 	* Cleaned and simplified allocation/claiming of wp config
> 	* arm_cmn_val_add_event() can't and won't fail anymore
> 	* Separated wp_combine from wp[] in event validation phase
> 	* use memset()/sizeof() when clearing an event
> 	* Still kept wp config allocator in separate functions - at least
> 	  for now
>
> v2:
>        * Wp config registers are allocated on node basis, instead
> 	  of using the same one globally
> 	* Use bitmap in the event structure to keep track on the
> 	  wp config registers assigned to the specific event.
> 	* The bitmap tracks only either UP (wp conf 0&1) or DOWN
> 	  (wp conf 2&3) registers.
> 	* Dropped the second patch
> 	  ("The patch set v2 is now in the internal mailing list")
> 	  as perf/sysfs doesn't really support items with the same
> 	  name even if visibility would handle them.
>        * Addressed a bunch of other comments by the author
> 	* https://lore.kernel.org/all/20240307230929.6233-2-ilkka@xxxxxxxxxxxxxxxxxxxxxx/
>
> v1:
> 	* https://lore.kernel.org/all/20240126221215.1537377-1-ilkka@xxxxxxxxxxxxxxxxxxxxxx/
>
>
> Ilkka Koskinen (2):
>  perf/arm-cmn: Decouple wp_config registers from filter group number
>  perf/arm-cmn: Enable support for tertiary match group
>
> drivers/perf/arm-cmn.c | 116 +++++++++++++++++++++++++++++++++--------
> 1 file changed, 93 insertions(+), 23 deletions(-)
>
> --
> 2.43.0