Re: [PATCH v3 07/10] arm64: dts: imx8qm-mek: add flexcan support

[Marc Kleine-Budde]

On 22.04.2024 15:50:09, Frank Li wrote:
> Add flexcan[1,2,3] support for imx8qm-mek board.
> 
> Signed-off-by: Frank Li <Frank.Li@xxxxxxx>
> ---
>  arch/arm64/boot/dts/freescale/imx8qm-mek.dts | 80 ++++++++++++++++++++++++++++
>  1 file changed, 80 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8qm-mek.dts b/arch/arm64/boot/dts/freescale/imx8qm-mek.dts
> index 3ab2fab7f7fa3..62ea3efd1ee2c 100644
> --- a/arch/arm64/boot/dts/freescale/imx8qm-mek.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8qm-mek.dts
[...]
> @@ -433,6 +492,27 @@ IMX8QM_QSPI0B_SS1_B_LSIO_QSPI0B_SS1_B     0x06000021
>  		>;
>  	};
>  
> +	pinctrl_flexcan1: flexcan0grp {
> +		fsl,pins = <
> +			IMX8QM_FLEXCAN0_TX_DMA_FLEXCAN0_TX			0x21
> +			IMX8QM_FLEXCAN0_RX_DMA_FLEXCAN0_RX			0x21
> +		>;
> +	};
> +
> +	pinctrl_flexcan2: flexcan1grp {
> +		fsl,pins = <
> +			IMX8QM_FLEXCAN1_TX_DMA_FLEXCAN1_TX			0x21
> +			IMX8QM_FLEXCAN1_RX_DMA_FLEXCAN1_RX			0x21
> +			>;

The indention of the closing ">" looks strange.

> +	};
> +
> +	pinctrl_flexcan3: flexcan3grp {
> +		fsl,pins = <
> +			IMX8QM_FLEXCAN2_TX_DMA_FLEXCAN2_TX			0x21
> +			IMX8QM_FLEXCAN2_RX_DMA_FLEXCAN2_RX			0x21
> +			>;

Same here.

> +	};
> +
>  	pinctrl_lpuart0: lpuart0grp {
>  		fsl,pins = <
>  			IMX8QM_UART0_RX_DMA_UART0_RX				0x06000020
> 
> -- 
> 2.34.1
> 
> 
>

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Attachment: signature.asc
Description: PGP signature