Re: [PATCH 1/6] dt-bindings: mmc: renesas,sdhi: Drop 'items' keyword

[Krzysztof Kozlowski]

On 23/04/2024 09:21, Lad, Prabhakar wrote:
> Hi Krzysztof,
> 
> Thank you for the review.
> 
> On Tue, Apr 23, 2024 at 7:29 AM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
>>
>> On 22/04/2024 23:30, Prabhakar wrote:
>>> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
>>>
>>> Drop 'items' keyword from compatible list which have single const value.
>>>
>>> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
>>> ---
>>>  .../devicetree/bindings/mmc/renesas,sdhi.yaml  | 18 ++++++------------
>>>  1 file changed, 6 insertions(+), 12 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
>>> index 29f2400247eb..90c8b1b727a8 100644
>>> --- a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
>>> +++ b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
>>> @@ -12,16 +12,11 @@ maintainers:
>>>  properties:
>>>    compatible:
>>>      oneOf:
>>> -      - items:
>>> -          - const: renesas,sdhi-sh73a0  # R-Mobile APE6
>>> -      - items:
>>> -          - const: renesas,sdhi-r7s72100 # RZ/A1H
>>> -      - items:
>>> -          - const: renesas,sdhi-r7s9210 # SH-Mobile AG5
>>> -      - items:
>>> -          - const: renesas,sdhi-r8a73a4 # R-Mobile APE6
>>> -      - items:
>>> -          - const: renesas,sdhi-r8a7740 # R-Mobile A1
>>> +      - const: renesas,sdhi-sh73a0  # R-Mobile APE6
>>> +      - const: renesas,sdhi-r7s72100 # RZ/A1H
>>> +      - const: renesas,sdhi-r7s9210 # SH-Mobile AG5
>>> +      - const: renesas,sdhi-r8a73a4 # R-Mobile APE6
>>> +      - const: renesas,sdhi-r8a7740 # R-Mobile A1
>>
>> That's just an enum.
>>
> Are you suggesting to group them into a single enum instead...?

Yes. That's preferred form, easier to read, because it clearly documents
that binding enumerates.

But just in case you start changing all const to enums: don't. Comment
is for this patch, since you already want to touch these things.

Best regards,
Krzysztof