Re: [PATCH 09/10] x86/rcu: Add rcu_preempt_count

[Frederic Weisbecker]

Le Tue, Apr 23, 2024 at 05:02:35PM +0800, Lai Jiangshan a écrit :
> Hello, Frederic
> 
> Thanks for reviewing.
> 
> On Mon, Apr 22, 2024 at 7:05 PM Frederic Weisbecker <frederic@xxxxxxxxxx> wrote:
> 
> > > +
> > > +/* We use the MSB mostly because its available */
> >
> > I think you can safely remove the "We " from all the comments :-)
> 
> The file is mainly copied from arch/x86/include/asm/preempt.h.
> I will rephrase sentences in later iterations.
> 
> >
> > > +#define RCU_PREEMPT_UNLOCK_SPECIAL_INVERTED  0x80000000
> >
> > How about RCU_PREEMPT_UNLOCK_FASTPATH ?
> 
> 
> I'm not good at naming. But the MSB really means exactly the opposite
> of current->rcu_read_unlock_special and I think "UNLOCK_SPECIAL_INVERTED"
> fits the meaning.

Right but I tend to think a constant should tell what something is, not what
something is not.

FWIW, p->rcu_read_unlock_special could even be renamed to p->rcu_read_unlock_slowpath

Thanks.