Re: [PATCH] bitops: Change function return types from long to int

[Thorsten Blum]

On 22. Apr 2024, at 17:55, Arnd Bergmann <arnd@xxxxxxxx> wrote:
> On Mon, Apr 22, 2024, at 16:30, Thorsten Blum wrote:
>> On 22. Apr 2024, at 09:44, Amadeusz Sławiński 
>> <amadeuszx.slawinski@xxxxxxxxxxxxxxx> wrote:
>>> 
>>> I don't mind the idea, but in the past I've send some patches trying to align some arch specific implementations with asm-generic ones. Now you are changing only asm-generic implementation and leaving arch specific ones untouched (that's probably why you see no size change on some of them).
>> 
>> I would submit architecture-specific changes in another patch set to keep it
>> simple and to be able to review each arch separately.
> 
> I can generally merge such a series with architecture specific
> changes through the asm-generic tree, with the appropriate Acks
> from the maintainers.

Ok.

I would still prefer to keep this patch free from arch-specific changes, if
possible. The patch improves architectures that use the generic bitops
functions (e.g., arm64) and doesn't impact any arch-specific implementations,
unless I'm missing something.

Thanks,
Thorsten