Re: [PATCH v2 2/4] ASoC: qcom: common: add Display port Jack function

From: Johan Hovold
Date: Tue Apr 23 2024 - 08:07:50 EST


On Mon, Apr 22, 2024 at 02:43:52PM +0100, Srinivas Kandagatla wrote:

> static const struct snd_soc_dapm_widget qcom_jack_snd_widgets[] = {
> SND_SOC_DAPM_HP("Headphone Jack", NULL),
> SND_SOC_DAPM_MIC("Mic Jack", NULL),
> + SND_SOC_DAPM_SPK("HDMI/DP0 Jack", NULL),
> + SND_SOC_DAPM_SPK("HDMI/DP1 Jack", NULL),
> + SND_SOC_DAPM_SPK("HDMI/DP2 Jack", NULL),

Shouldn't these be split in dedicated HDMI and DP jacks too? What if you
have a machine with HDMI and DP jacks which would otherwise both claim
"HDMI/DP0"?

Johan