Re: [PATCH v1 2/2] ASoC: qcom: qcm6490: Add machine driver for qcm6490

[Konrad Dybcio]

On 4/2/24 11:20, Mohammad Rafi Shaik wrote:
> On 3/30/2024 12:09 AM, Dmitry Baryshkov wrote:
> > Hi,
> >
> > On Fri, 29 Mar 2024 at 17:20, Mohammad Rafi Shaik <quic_mohs@xxxxxxxxxxx> wrote:
> > > On 3/27/2024 6:39 PM, Dmitry Baryshkov wrote:
> > >
> > > On Wed, 27 Mar 2024 at 13:34, Mohammad Rafi Shaik <quic_mohs@xxxxxxxxxxx> wrote:
> >
> > Please turn off HTML mail composition and never ever send HTML email
> > to OSS mailing lists.
> > Now quotation levels are broken...
> >
> > > Add machine driver for qcm6490 SoC.
> > >
> > > This initial supports which includes WSA883x Speakers with onboard DMIC
> > > connected to internal LPASS codec via VA macros respectively and also
> > > WCD937x based headset.
> > >
> > > Add compatible for sound card on Qualcomm qcs6490 boards.
> > >
> > > Granted that qcm6490 is similar to sc7280, is there any reason why you
> > > can not use one of the existing sound card drivers? Like sc7280.c or
> > > sc8280xp.c?
> > >
> > > The qcs6490/qcm6490 has additional interfaces like MI2S, which requires additional machine driver modification.
> > >
> > > Example : Required new DAPM widget change in machine driver for MI2S interface which is specific to qcs6490/qcm6490.
> > >
> > > So, using new qcm6490 machine driver.
> > >
> > > Will try to use existing sc8280xp.c machine driver.
> >
> > What about sc7280? In the end, qcm6490 is sc7280 with different firmware / spin.
>
> The sc7280 is tightly linked with realtek codec. which will only support for chrome.

Perhaps we should rename it and stop suggesting it's for all 7280-like platforms then..

> The sc8280xp.c machine driver is more suitable for qcm6490, will use same sc8280xp.

This in turn, should it become something like snd-qcom-audioreach?

Konrad