Re: [PATCH v6 3/4] media: i2c: add MAX96717 driver

[Julien Massot]

Hi Sakari,

On 4/12/24 13:23, Sakari Ailus wrote:
> Hi Julien,
>
> Thanks for the update.
>
> Could you also cc me to the possible further updates, please?
>
> On Mon, Mar 25, 2024 at 02:16:33PM +0100, Julien Massot wrote:
> > This driver handles the MAX96717 serializer in tunnel mode.
> > All incoming CSI traffic will be tunneled through the GMSL2
> > link.
> >
> > The MAX96717 driver can handle MAX96717 and MAX96717F variants
> > with the same "maxim,max96717f" compatible.
> >
> > Signed-off-by: Julien Massot <julien.massot@xxxxxxxxxxxxx>
> > ---
> > Change since v5:
> >   - set the driver compatible back to MAX96717F that can be used as a fallback for MAX96717
> >
> > Change since v4:
> >   - make the driver compatible with MAX96717 instead of MAX96717F
> >   - Add the device id for the MAX96717
> >   - remove hw_data structure for now, it can be usefull later for handling different serializers e.g max9295
> >
> > Change since v3:
> >   - Maintainers: align to the new binding path
> >   - Kconfig: better describe the symbol
> >   - store the v4l2_mbus_config_mipi_csi2 structure instead of the full endpoint in the driver private structure
> >   - use MAX96717_PAD_SINK/SOURCE instead of 0/1 for pad intialization
> >   - Removed incorrect call to fwnode_handle_put(priv->sd.fwnode)
> >   - Use unsigned int instead of u8
> >   - Allocate clk name out of the clk struct initialization
> >   - fixed multiline comment
> >   - Removed one unnecessary goto at the end of the probe function
> >
> > Change since v2:
> >   - Use CCI helpers instead of recoding register access
> >   - add missing bitfield header
> > ---
> >   MAINTAINERS                  |   7 +
> >   drivers/media/i2c/Kconfig    |  14 +
> >   drivers/media/i2c/Makefile   |   1 +
> >   drivers/media/i2c/max96717.c | 934 +++++++++++++++++++++++++++++++++++
> >   4 files changed, 956 insertions(+)
> >   create mode 100644 drivers/media/i2c/max96717.c
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index b43102ca365d..c43088157f6d 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -13277,6 +13277,13 @@ S:	Maintained
> >   F:	Documentation/devicetree/bindings/media/i2c/maxim,max96712.yaml
> >   F:	drivers/staging/media/max96712/max96712.c
> >   
> > +MAX96717 GMSL2 SERIALIZER DRIVER
> > +M:	Julien Massot <julien.massot@xxxxxxxxxxxxx>
> > +L:	linux-media@xxxxxxxxxxxxxxx
> > +S:	Maintained
> > +F:	Documentation/devicetree/bindings/media/i2c/maxim,max96717.yaml
> > +F:	drivers/media/i2c/max96717.c
> > +
> >   MAX9860 MONO AUDIO VOICE CODEC DRIVER
> >   M:	Peter Rosin <peda@xxxxxxxxxx>
> >   L:	alsa-devel@xxxxxxxxxxxxxxxx (moderated for non-subscribers)
> > diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
> > index 56f276b920ab..1a99396edbcf 100644
> > --- a/drivers/media/i2c/Kconfig
> > +++ b/drivers/media/i2c/Kconfig
> > @@ -1573,6 +1573,20 @@ config VIDEO_DS90UB960
> >   	  Device driver for the Texas Instruments DS90UB960
> >   	  FPD-Link III Deserializer and DS90UB9702 FPD-Link IV Deserializer.
> >   
> > +config VIDEO_MAX96717
> > +	tristate "Maxim MAX96717 GMSL2 Serializer support"
> > +	depends on OF && I2C && VIDEO_DEV && COMMON_CLK
> > +	select I2C_MUX
> > +	select GPIOLIB
> > +	select V4L2_CCI_I2C
>
> I think you'll also need MEDIA_CONTROLLER, VIDEO_V4L2_SUBDEV_API and
> V4L2_FWNODE.

You are right, will be fixed in v7.

> > +	help
> > +	  Device driver for the Maxim MAX96717 GMSL2 Serializer.
> > +	  MAX96717 serializers convert video on a MIPI CSI-2
> > +	  input to a GMSL2 output.
> > +
> > +	  To compile this driver as a module, choose M here: the
> > +	  module will be called max96717.
> > +
> >   endmenu
> >   
> >   endif # VIDEO_DEV

--
Julien Massot
Senior Software Engineer
Collabora Ltd.
Platinum Building, St John's Innovation Park, Cambridge CB4 0DS, UK
Registered in England & Wales, no. 5513718