Re: [PATCH v2] docs/MAINTAINERS: Update my email address
From: Bilbao, Carlos
Date: Tue Apr 23 2024 - 12:11:26 EST
Hello Akira,
On 4/23/2024 10:59 AM, Akira Yokosawa wrote:
> Hi Carlos,
>
> On Tue, 23 Apr 2024 10:19:14 -0500, Carlos Bilbao wrote:
>> In the near future, I will not have access to the email address I used as
>> maintainer of a number of things, mostly in the documentation. Update that
>> address to my personal email address (see Link) so I can continue
>> contributing and update .mailmap.
>>
>> Link: https://lore.kernel.org/all/BL1PR12MB58749FF2BFEDB817DE1FE6CBF82A2@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/
>> Signed-off-by: Carlos Bilbao <carlos.bilbao@xxxxxxx>
>> ---
>>
>> Changes since v1:
>> - Update .mailmap
>>
>> ---
>> .mailmap | 1 +
> [...]
>
>>
>> diff --git a/.mailmap b/.mailmap
>> index 1eb607efcc6e..4bac5578426a 100644
>> --- a/.mailmap
>> +++ b/.mailmap
>> @@ -113,6 +113,7 @@ Brian Silverman <bsilver16384@xxxxxxxxx> <brian.silverman@xxxxxxxxxxxxxxxxx>
>> Cai Huoqing <cai.huoqing@xxxxxxxxx> <caihuoqing@xxxxxxxxx>
>> Can Guo <quic_cang@xxxxxxxxxxx> <cang@xxxxxxxxxxxxxx>
>> Carl Huang <quic_cjhuang@xxxxxxxxxxx> <cjhuang@xxxxxxxxxxxxxx>
>> +Carlos Bilbao <carlos.bilbao@xxxxxxx> <carlos.bilbao.osdev@xxxxxxxxx>
>
> I'm afraid this won't do what you'd expect.
> Entries in .mailmap should look like:
>
> Full Name <new address> <old address>
>
> See gitmailmap(5) and git-check-mailmap(1) for further info.
I find it interesting that <new-email> <old-email> (as opposed to
<old-email> <new-email>) feels counterintuitive to me. Thanks for catching
this, Akira. I'm sending v3 right away.
>
> HTH, Akira
>
>
Best,
Carlos