Re: [PATCH 1/2] dmaengine: qcom: Drop hidma DT support

From: Konrad Dybcio
Date: Tue Apr 23 2024 - 12:23:23 EST




On 4/23/24 18:14, Rob Herring (Arm) wrote:
The DT support in hidma has been broken since commit 37fa4905d22a
("dmaengine: qcom_hidma: simplify DT resource parsing") in 2018. The
issue is the of_address_to_resource() calls bail out on success rather
than failure. This driver is for a defunct QCom server platform where
DT use was limited to start with. As it seems no one has noticed the
breakage, just remove the DT support altogether.

Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Signed-off-by: Rob Herring (Arm) <robh@xxxxxxxxxx>
---

Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>

Konrad